feat: use battery saving sync intervals #729
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Member
|
IMHO we could delay this feature to the next week, after Plan B, to avoid unforeseen bugs such as those caused by graph caching |
Collaborator
Author
|
Drafted for this:
And also for the fact that it doesn't even work yet the way it's supposed to work. |
Member
Indeed, I wasn't getting the expected logs |
- Update `ldk-node-android` dependency to version `v0.7.0-rc.17` - Update `ChannelDetails` extensions and UI mock data to include the new `claimableOnCloseSats` property required by the SDK update
ovitrif
force-pushed
the
feat/node-service-battery-save
branch
from
127663a to
8a6ad11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
2. Adds battery saving sync intervals when the app goes to the background
Description
When the app is backgrounded, the Lightning node now switches to battery-saving sync intervals using the new
RuntimeSyncIntervalsAPI from ldk-node. When the app returns to the foreground, normal sync intervals are restored. This reduces battery drain while keeping the node active for receiving payments.The SDK update also adds a new
claimableOnCloseSatsproperty to channel details, which is now included in mock data and extensions.Preview
N/a - No UI changes.
QA Notes
Test background behavior
Sync intervals entered battery saving modeSync intervals exited battery saving modeTest normal operation